Remove IMemoryManager interface#5703
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@tanjialiang thanks for the refactor!
There was a problem hiding this comment.
Move this to cc? thanks!
There was a problem hiding this comment.
Let' call this capacity?
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D47560079 |
|
This pull request was exported from Phabricator. Differential Revision: D47560079 |
Summary: Removing the interface as there is no use case needed for this interface Pull Request resolved: facebookincubator#5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: f07acbb51caf81b9f950e27a1bbcba72e9f17b52
|
This pull request was exported from Phabricator. Differential Revision: D47560079 |
|
@tanjialiang merged this pull request in fe3d937. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Summary: Removing the interface as there is no use case needed for this interface X-link: facebookincubator/velox#5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: f6bd797b780dcadbc7768bde9dba2317518a259a
Summary: Removing the interface as there is no use case needed for this interface X-link: facebookincubator/velox#5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: f6bd797b780dcadbc7768bde9dba2317518a259a
Summary: Removing the interface as there is no use case needed for this interface X-link: facebookincubator/velox#5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: f6bd797b780dcadbc7768bde9dba2317518a259a
3 participants
Removing the interface as there is no use case needed for this interface